Skip to content

chore: indicate jetkvm version from user-agent #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

chore: indicate jetkvm version from user-agent #606

wants to merge 1 commit into from
+19 −1

Conversation

ym
Copy link
Contributor

@ym ym commented Jun 12, 2025

TODO:

  • Allow users to override the user agent and choose whether to send the version number.

IDisposable
IDisposable approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@IDisposable IDisposable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful to using the POOL.NTP.ORG servers, and doesn't really need to be configurable. Can we ship this as is and add the user-agent configurability to the network settings enhancements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IDisposable IDisposable IDisposable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ym @IDisposable